update #1
Merged
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- Comment/javadoc refinement Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- Fix incorrect usage. It's not thread-safe when comparing and updating `minRt`, but it's okay since the actual minimum RT often matches free load. Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
update README to add coverage icon
- Added a GrpcTestServer to abstract common server logic - Refactor with new added `GrpcTestServer`
- The method from the signature will return the method of interface, so we need to resolve declared method in target class Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
….passCheck() method
- Spilt DataSource into two types: ReadableDataSource and WritableDataSource - The AbstractDataSource now is read-only - Refactor the file data source for writable implementation - Rename: ConfigParser -> Converter (represents both encoder `T -> S` and decoder `S -> T`) - Some other refinement Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- Refine code about writable datasource Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- Add `close` method in WritableDataSource (to extend AutoCloseable in JDK 1.7 later) - Separate the writable file data source from original class - Add a sample to show how to register data sources via Sentinel init mechanism - Separate a writable data source registry from original handler to make it clear Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- Add method to check if the resource is modified in `AutoRefreshDataSource` - Implement FileWritableDataSource
- Some refinement for file data source - Add resource name checking in FlowRuleManager to avoid NPE Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…tation (#126) - Abstract a universal `MetricsRepository` interface so that users can implement their own metrics persistence. - Reuse original in-memory implementation (`InMemoryMetricsRepository`) as the default repository. Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- Support extensible `SlotChainBuilder` using SPI mechanism - Add a `SlotChainProvider` to load slot chain builder and create new slot chains Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…WarmUpRateLimiterController Signed-off-by: Carpenter Lee <hooleeucas@163.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Carpenter Lee <hooleeucas@163.com>
… ClassNotFoundException thrown by Nacos client (#438)
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…r when loading SPI Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…text in Tracer Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…#465) - reuse old map size to avoid rearrange and rehash the map
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- Apply awaitility to core tests - Cache maven local repo in Travis
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
… and add basic test cases Signed-off-by: Eric Zhao <sczyh16@gmail.com>
* Extract getRule in BlockException and refine override methods in subclasses Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- The NPE will occur when multiple threads are trying to create the connection group for the same namespace Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews