Skip to content

Watch gitopscluster CRs #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 5, 2022
Merged

Watch gitopscluster CRs #11

merged 11 commits into from
May 5, 2022

Conversation

sarataha
Copy link
Member

@sarataha sarataha added the enhancement New feature or request label Apr 19, 2022
bigkevmcd
bigkevmcd reviewed Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, there are a couple of minor typos.

The fact that this only works with the private cluster-controller is perhaps a strong indicator that it should now be private too.

sarataha and others added 4 commits April 20, 2022 11:51
@sarataha @bigkevmcd
Update controllers/clusterbootstrapconfig_controller_test.go
4c2ab50 
Co-authored-by: Kevin McDermott <kevin@weave.works>
@sarataha @bigkevmcd
Update controllers/clusterbootstrapconfig_controller_test.go
9d412e5 
Co-authored-by: Kevin McDermott <kevin@weave.works>
@sarataha @bigkevmcd
Update controllers/clusterbootstrapconfig_controller.go
41fae10 
Co-authored-by: Kevin McDermott <kevin@weave.works>
@sarataha @bigkevmcd
Update controllers/clusterbootstrapconfig_controller.go
93026bb 
Co-authored-by: Kevin McDermott <kevin@weave.works>
foot
foot reviewed May 4, 2022
View reviewed changes
foot added 2 commits May 4, 2022 14:08
@foot
Fix up ready condition checking
9dd5abf 
- Status: Ready -> Type: Ready, Status: True
@foot
Update readme
91cb26b
foot
foot approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@foot foot merged commit 235f6d5 into main May 5, 2022
@foot foot deleted the add-watch-gitopscluster branch May 5, 2022 06:58
@foot foot mentioned this pull request May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkevmcd bigkevmcd bigkevmcd left review comments

@foot foot foot approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarataha @foot @bigkevmcd