Skip to content

Configure the github release action for private go modules #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2022
Merged

Configure the github release action for private go modules #12

merged 2 commits into from
May 5, 2022

Conversation

foot
Copy link
Collaborator

@foot foot commented May 5, 2022 •
edited
Loading

  • cluster-controller (private repo) was introduced as a go dep in Watch gitopscluster CRs #11 and we need to do the classic git hacks to allow go mod to read the new private repo dependency

foot added 2 commits May 5, 2022 09:45
@foot
Configure the github release action for private go modules
00f0e93 
- cluster-controller (private repo) was introduced as a go dep and we
  need to do the classic git hacks to allow go mod to read the new
  private repo dependency
@foot
Configure docker host's git for private go modules too
f9d8ec8
sarataha
sarataha approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@sarataha sarataha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@foot foot merged commit f882c84 into main May 5, 2022
@foot foot deleted the fix-release-github-action branch May 5, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sarataha sarataha sarataha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foot @sarataha