fix: controllers/tc00005x tests and the manual approval stuck in loop bug #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I disabled 51 and 52 tests as they are failing 100% of the time, it's not flaky, but we don't know what causes the issue. With manual approval, it stuck in a loop between "drift detected" and "in progress". This is a known issue [^1]. Closes #905 Related to #890 [^1]: #890 Signed-off-by: Balazs Nadasdi <balazs@weave.works>
yitsushi
changed the title
After a bit of poking, if I remove all changed from the commit, except the `patcher := ...` and the `patcher.Patch` call (so the `finalizeStatus` does literally nothing, but patches the "expected nothing"), it still causes an issue. If I keep everything from the commit, but move the `patcher :=` line into the `defer` function, tests are happy. We already have status patching everywhere (without this commit everything worked). The Patcher in this commit should just patch the diff calculated in finalizeStatus. I assume it a weird issue how the whole codebase tosses around the `&terraform` reference and makes Patch calls somewhere else in the State Machine. Fixes #890 References: * #890 Signed-off-by: Balazs Nadasdi <balazs@weave.works>
yitsushi
force-pushed
the
905-fix-5x-tests
branch
from
008a911 to
538d8ec
Compare
chanwit
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: controllers/tc00005x tests
Closes #905
fix: reconcile stuck in a loop with manual approval
After a bit of poking, if I remove all changed from the commit, except
the
patcher := ...and thepatcher.Patchcall (so thefinalizeStatusdoes literally nothing, but patches the "expectednothing"), it still causes an issue.
If I keep everything from the commit, but move the
patcher :=lineinto the
deferfunction, tests are happy.We already have status patching everywhere (without this commit
everything worked). The Patcher in this commit should just patch the
diff calculated in finalizeStatus.
I assume it a weird issue how the whole codebase tosses around the
&terraformreference and makes Patch calls somewhere else in the StateMachine.
Closes #890