-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wpt tests for <meta name=color-scheme> to not depend on the color-scheme computed value (before whatwg/html#7226) #31268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are valid even without the spec pull request, right?
No, because they assert that |
@lilles I guess I could remove that assert and land it, if you want? |
(then add that assert in another PR) |
sgtm, what suits you best. |
…lor-scheme computed value (before whatwg/html#7226) This makes the tests valid both with and without the spec change proposed above. Will send a follow-up PR to test the spec change. This makes the assumption that the initial browser's color-scheme is light, which I think is a reasonable assumption to run these tests under. An alternative would have to allow both "light" and "dark" wherever we check for "normal" now (which loses test coverage in practice), or I could complicate the test to compute the initial color-scheme using an iframe or what not (but that complicates everything more).
Alright, let's do that. |
Sent the follow-up in #31268. |
Err, wrong tab-complete :) #31271 |
This is reasonable, but it should be documented in the test as an assumption, so anyone producing a default-dark browser can tell why they're failing the test and that the test should be fixed, rather than their browser. ^_^ |
|
This makes the tests valid both with and without the spec change
proposed above. Will send a follow-up PR to test the spec change.
This makes the assumption that the initial browser's color-scheme is
light, which I think is a reasonable assumption to run these tests
under.
An alternative would have to allow both "light" and "dark" wherever we
check for "normal" now (which loses test coverage in practice), or I
could complicate the test to compute the initial color-scheme using an
iframe or what not (but that complicates everything more).