URL: run IdnaTestV2.txt in WPT #38080
Conversation
annevk
requested review from
domenic,
valenting,
achristensen07,
TimothyGu and
ricea
|
Analyzing the remaining failures in WebKit they are all about https://www.unicode.org/reports/tr46/#UseSTD3ASCIIRules. Not just the code points listed there, but their I was able to filter IPV4-like inputs in a way that captures all of the issues with them. I suppose instead of excluding them I could also change the expectation to failure. Thoughts welcome. |
|
I think this is ready for inclusion now. I have removed all tests that have outstanding UTS46 feedback. WebKit has 0 failures, Gecko 52, and Chromium 712. Unfortunately this is only about a third of the test suite, but we can improve this over time as UTS46 considers our feedback. |
|
Looks good! But why disable the Bidi tests? |
|
CheckBidi has at least one UB issue (empty trailing label) and also has outstanding feedback that it might be too strict: whatwg/url#543. I have submitted the former to Unicode and plan on submitting the latter either once I've gotten a better idea of what to recommend or once I've given up on getting a better idea and decide to at the very least raise the issue. WebKit does currently pass all the CheckBidi tests, but other browsers and jsdom/whatwg-url do not, and I think the feedback around it being too strict has merit and deserves further review before we enshrine the status quo. |
| } | ||
| } | ||
| return output; | ||
| } |
There was a problem hiding this comment.
It would be slightly nicer for other consumers like jsdom if this preprocessing, as well as the prepending of https:// and appending of /x, was done by the Python script that output the JSON file.
There was a problem hiding this comment.
I did not want to do that as I want URLHost (it'll happen one day!) to be able to consume the actual test.
For whatwg/url#341.
These tests work and can run in browsers. The upstream tests have issues as indicated in
IdnaTestV2-feedback.txt. If folks would be willing to take a look at this that would be appreciated. Especially if there are further oversights in the upstream tests we'd want to call out to the Unicode Consortium.(Design feedback is also welcome of course. The code isn't great and still has some
print()statements. Happy to clean it up, especially given some direction.)cc @ricea @TimothyGu @achristensen07 @domenic @valenting @karwa