Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission/selectors opera #48

Closed
wants to merge 5 commits into from
Closed

Conversation

darobin
Copy link
Contributor

@darobin darobin commented Apr 4, 2013

No description provided.

@myakura
Copy link
Contributor

myakura commented Nov 12, 2013

Now that work on lv2 has stopped, do we still need tests for it?

@sideshowbarker
Copy link
Contributor

@darobin this PR has been open for more than one year

@sideshowbarker
Copy link
Contributor

@darobin radio check

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 17, 2015

Most of this landed over the years; the remainder is now #1562.

@Ms2ger Ms2ger closed this Jan 17, 2015
@sideshowbarker sideshowbarker deleted the submission/selectors-opera branch June 18, 2015 07:32
jgraham added a commit that referenced this pull request Apr 13, 2017
Explicitly pass the url_base to filesystem_path so the correct paths can be constructed.
jgraham pushed a commit that referenced this pull request Apr 21, 2017
Add a finish handler to the Servo executor.
jgraham added a commit that referenced this pull request Apr 24, 2017
88c5c5b6bb chore(package): bump version
8b3bc38a24 chore(package): bump version
c64fe13a42 chore(package): update deps
a0bccdf485 fix "Trailing comma in extended attribute" error (#63)
62633a1025 Remove support for MapClass (no longer valid in WebIDL) (#62)
3a7d1bbe3e Merge pull request #61 from w3c/annotated_types
49ea372ba3 Fix spaces in JSON output for updated test
7488ee661f docs(README): fix markdown.
5530e9fecc Adapt test to support for annotated types
a387b679ca Add support for annotated types
ffe9400aba Merge pull request #58 from SaschaNaz/namespace
9a154bb963 implement namespace
830d19191f chore(package): bump version
e5771f11e8 Revert "style: use U.S. English"
8c712c9cb8 chore(package): bump version
8ee9a85ad8 style: use U.S. English
bc7b7c6897 style(lib): beautify code
96699646e1 chore(package): bump version
86ea904cbf chore(package): update dependencies
44d7b22851 Merge pull request #57 from TimothyGu/develop
0b5300ec76 Make writer less strict about generic idlType's type
064622bf59 Add support for records
fcb88fb1ac Merge pull request #50 from w3c/refactor
a23527043e refactor(webidl.js): move WebIDLParseError
c64e97c3b8 Merge pull request #49 from w3c/amd_compat
d1e704bd40 feat(lib): add AMD export support (closes #48)
5458831df8 style(writer.js): fix whitespace
481c29427a style(webidl2.js): fix whitespace
ed24e286ee chore(package): update deps
2668a8be5f docs(README): fixup markdown highlighting
9df3430244 Merge pull request #47 from mkwtys/fix-default
ec61c0a096 Merge branch 'halton-replace_expect' into develop
fb59b13c2c Really be deterministic
128d7335bb Remove reliance on undeterministic object key order
7bf2df2276 Confirm support for union in typedef
1b5b83438e Remove test of now invalid nested typdef
2d8cd93bd4 Update location of expect.js library
1ed22de9b5 Correct jsondiffpatch location.
a2e2f8e902 Bump microtime to 2.1.1
23b63723e9 Expand writer support
9cc1281a1c Accept wider (but still incomplete) set of allowed syntax for extended attributes.
cb04f7777c Identifier allow `-`
d9b4989425 Merge pull request #39 from markandrus/develop
1ab320df8d Merge pull request #37 from artillery/develop
524000bfd6 Merge pull request #31 from othree/in-draft
99127088c2 Fix `"default": undefined`
191685b05f Really be deterministic
300b1e0fae Remove reliance on undeterministic object key order
61c8e65035 Confirm support for union in typedef
f0cd831c6c Remove test of now invalid nested typdef
77b5e3df87 Update location of expect.js library
f84b8e684c Merge pull request #44 from halton/fix_jsondiffpatch
b52117cf05 Merge pull request #43 from halton/bump_microtime
65382bf16b Replace expect.js with expct
be6c2e21e9 Correct jsondiffpatch location.
0b0fa3e92d Bump microtime to 2.1.1
e470735423 Expand writer support
9e2ccfc940 Accept wider (but still incomplete) set of allowed syntax for extended attributes.
989591f675 Allow trailing comma in enum
9385d07a54 Identifier allow `-`

git-subtree-dir: resources/webidl2
git-subtree-split: 88c5c5b6bb675d0d95ae3ec4db3258768d0c8fc0
jgraham added a commit that referenced this pull request Apr 26, 2017
)

88c5c5b6bb chore(package): bump version
8b3bc38a24 chore(package): bump version
c64fe13a42 chore(package): update deps
a0bccdf485 fix "Trailing comma in extended attribute" error (#63)
62633a1025 Remove support for MapClass (no longer valid in WebIDL) (#62)
3a7d1bbe3e Merge pull request #61 from w3c/annotated_types
49ea372ba3 Fix spaces in JSON output for updated test
7488ee661f docs(README): fix markdown.
5530e9fecc Adapt test to support for annotated types
a387b679ca Add support for annotated types
ffe9400aba Merge pull request #58 from SaschaNaz/namespace
9a154bb963 implement namespace
830d19191f chore(package): bump version
e5771f11e8 Revert "style: use U.S. English"
8c712c9cb8 chore(package): bump version
8ee9a85ad8 style: use U.S. English
bc7b7c6897 style(lib): beautify code
96699646e1 chore(package): bump version
86ea904cbf chore(package): update dependencies
44d7b22851 Merge pull request #57 from TimothyGu/develop
0b5300ec76 Make writer less strict about generic idlType's type
064622bf59 Add support for records
fcb88fb1ac Merge pull request #50 from w3c/refactor
a23527043e refactor(webidl.js): move WebIDLParseError
c64e97c3b8 Merge pull request #49 from w3c/amd_compat
d1e704bd40 feat(lib): add AMD export support (closes #48)
5458831df8 style(writer.js): fix whitespace
481c29427a style(webidl2.js): fix whitespace
ed24e286ee chore(package): update deps
2668a8be5f docs(README): fixup markdown highlighting
9df3430244 Merge pull request #47 from mkwtys/fix-default
ec61c0a096 Merge branch 'halton-replace_expect' into develop
fb59b13c2c Really be deterministic
128d7335bb Remove reliance on undeterministic object key order
7bf2df2276 Confirm support for union in typedef
1b5b83438e Remove test of now invalid nested typdef
2d8cd93bd4 Update location of expect.js library
1ed22de9b5 Correct jsondiffpatch location.
a2e2f8e902 Bump microtime to 2.1.1
23b63723e9 Expand writer support
9cc1281a1c Accept wider (but still incomplete) set of allowed syntax for extended attributes.
cb04f7777c Identifier allow `-`
d9b4989425 Merge pull request #39 from markandrus/develop
1ab320df8d Merge pull request #37 from artillery/develop
524000bfd6 Merge pull request #31 from othree/in-draft
99127088c2 Fix `"default": undefined`
191685b05f Really be deterministic
300b1e0fae Remove reliance on undeterministic object key order
61c8e65035 Confirm support for union in typedef
f0cd831c6c Remove test of now invalid nested typdef
77b5e3df87 Update location of expect.js library
f84b8e684c Merge pull request #44 from halton/fix_jsondiffpatch
b52117cf05 Merge pull request #43 from halton/bump_microtime
65382bf16b Replace expect.js with expct
be6c2e21e9 Correct jsondiffpatch location.
0b0fa3e92d Bump microtime to 2.1.1
e470735423 Expand writer support
9e2ccfc940 Accept wider (but still incomplete) set of allowed syntax for extended attributes.
989591f675 Allow trailing comma in enum
9385d07a54 Identifier allow `-`

git-subtree-dir: resources/webidl2
git-subtree-split: 88c5c5b6bb675d0d95ae3ec4db3258768d0c8fc0
AutomatedTester referenced this pull request in AutomatedTester/web-platform-tests Dec 1, 2017
chromium-wpt-export-bot pushed a commit that referenced this pull request Jul 17, 2019
…se functionality

This change sets the groundwork for the toast closebutton, by
adding an attribute to set the closebutton content,
creating a closeButton property to reflect that attribute,
and adding an event listener to close the toast when the closebutton is pressed.

This change implements the close button API described in
(https://github.com/jackbsteinberg/std-toast/blob/eec7728f7082a897d777181ac07b0448062ffca5/README.md),
and is the subject of debate on issue #48 on the explainer here
jackbsteinberg/std-toast#48.

Future CLs will add the closeButton option for showToast
(https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options)
Link: https://chromium-review.googlesource.com/c/chromium/src/+/1706453

Bug:972945
Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed
chromium-wpt-export-bot pushed a commit that referenced this pull request Jul 18, 2019
…se functionality

This change sets the groundwork for the toast closebutton, by
adding an attribute to set the closebutton content,
creating a closeButton property to reflect that attribute,
and adding an event listener to close the toast when the closebutton is pressed.

This change implements the close button API described in
(https://github.com/jackbsteinberg/std-toast/blob/eec7728f7082a897d777181ac07b0448062ffca5/README.md),
and is the subject of debate on issue #48 on the explainer here
jackbsteinberg/std-toast#48.

Future CLs will add the closeButton option for showToast
(https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options)
Link: https://chromium-review.googlesource.com/c/chromium/src/+/1706453

Bug: 972945
Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699269
Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678530}
chromium-wpt-export-bot pushed a commit that referenced this pull request Jul 18, 2019
…se functionality

This change sets the groundwork for the toast closebutton, by
adding an attribute to set the closebutton content,
creating a closeButton property to reflect that attribute,
and adding an event listener to close the toast when the closebutton is pressed.

This change implements the close button API described in
(https://github.com/jackbsteinberg/std-toast/blob/eec7728f7082a897d777181ac07b0448062ffca5/README.md),
and is the subject of debate on issue #48 on the explainer here
jackbsteinberg/std-toast#48.

Future CLs will add the closeButton option for showToast
(https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options)
Link: https://chromium-review.googlesource.com/c/chromium/src/+/1706453

Bug: 972945
Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699269
Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678530}
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
…se functionality

This change sets the groundwork for the toast closebutton, by
adding an attribute to set the closebutton content,
creating a closeButton property to reflect that attribute,
and adding an event listener to close the toast when the closebutton is pressed.

This change implements the close button API described in
(https://github.com/jackbsteinberg/std-toast/blob/eec7728f7082a897d777181ac07b0448062ffca5/README.md),
and is the subject of debate on issue web-platform-tests#48 on the explainer here
jackbsteinberg/std-toast#48.

Future CLs will add the closeButton option for showToast
(https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options)
Link: https://chromium-review.googlesource.com/c/chromium/src/+/1706453

Bug: 972945
Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699269
Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678530}
fred-wang added a commit that referenced this pull request Sep 11, 2019
…m in-flow children.

This basically duplicates existing tests but adds some absolute-positioned
and display: none <mn> that should't affect layout. Note that the case of
float is still undecided (see #48).
fred-wang added a commit that referenced this pull request Sep 11, 2019
…m in-flow children. (#18990)

This basically duplicates existing tests but adds some absolute-positioned
and display: none <mn> that should't affect layout. Note that the case of
float is still undecided (see #48).
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 3, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 3, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 3, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 3, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 4, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 4, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 5, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 6, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747644}
Hexcles pushed a commit that referenced this pull request Mar 6, 2020
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747644}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants