Fix: Stability issues with VS Code extension #3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vsix for testing (you'll have to remove the .zip extension and side load it) |
sarvaje
approved these changes
Nov 20, 2019
|
@molant there is a coverage error :( |
The VS Code extension could end up breaking `node_modules` in the workspace or the global shared folder. This was caused because we were installing `hint@latest` in the workspace and because that process took too long and the user might closed the editor before it was ended. To avoid that we now let the user manage their own `hint` installation in the workspace, no more prompting about installation. If no version can be loaded from the workspace, the shared one (`hint@latest`) will be used. Also, the shared version is updated after 2 minutes instead of immediately and only if the shared version has been successfully loaded. If the user already has a workspace version there is no point in updating the shared one as it will not be used.
molant
force-pushed
the
fix/extension-vscode-lifecycle
branch
from
eeec027
to
87e602a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)
The VS Code extension could end up breaking
node_modulesin theworkspace or the global shared folder. This was caused because we were
installing
hint@latestin the workspace and because that processtook too long and the user might closed the editor before it was
ended.
To avoid that we now let the user manage their own
hintinstallationin the workspace, no more prompting about installation. If no version
can be loaded from the workspace, the shared one (
hint@latest) willbe used.
Also, the shared version is updated after 2 minutes instead of
immediately and only if the shared version has been successfully
loaded.
If the user already has a workspace version there is no point in
updating the shared one as it will not be used.