fix(index): emit warnings as an instance of {Error} instead of {String}
#365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxleaver
requested review from
alexander-akait and
michael-ciniawsky
as code owners
alexander-akait
requested changes
Jun 27, 2018
|
/cc @Kovensky can you test this too, thanks |
michael-ciniawsky
changed the title
warnings as an instance of {Error} instead of {String}
michael-ciniawsky
suggested changes
Jul 9, 2018
| .process(css, options) | ||
| .then((result) => { | ||
| result.warnings().forEach((msg) => this.emitWarning(msg.toString())) | ||
| result.warnings().forEach((msg) => this.emitWarning(new Error(msg.toString()))) |
There was a problem hiding this comment.
I need to check the Postcss API docs, but I think warnings can contain location info and a code frame if the plugin author used the appropiated PostCSS Plugin API. If that's the case it would be better to reuse the code located in lib/Error.js and create a new class LoaderWarning (lib/Warning.js) based upon that to be consistent in terms of formatting
michael-ciniawsky
added
scope: webpack
status: pending
pr: refactor
and removed
pr: review
labels
Merged
6 tasks
|
Closing in favor of 6eb82be Thx |
michael-ciniawsky
added
status: declined
and removed
ci: ok
pr: refactor
priority: medium
status: pending
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings are currently sent to webpack as strings. However, Webpack's emitWarning function expects an error, as described in their API. This results in the errors described in #350. This PR simply changes the warnings emitted by postcss-loader from strings to an error instance.
TypeSemVerIssuesChecklist