Skip to content

fix(index): emit warnings as an instance of {Error} instead of {String} #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(index): emit warnings as an instance of {Error} instead of {String} #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ module.exports = function loader (css, map, meta) {
return postcss(plugins)
.process(css, options)
.then((result) => {
result.warnings().forEach((msg) => this.emitWarning(msg.toString()))
result.warnings().forEach((msg) => this.emitWarning(new Error(msg.toString())))
Copy link
Member

@michael-ciniawsky michael-ciniawsky Jul 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check the Postcss API docs, but I think warnings can contain location info and a code frame if the plugin author used the appropiated PostCSS Plugin API. If that's the case it would be better to reuse the code located in lib/Error.js and create a new class LoaderWarning (lib/Warning.js) based upon that to be consistent in terms of formatting


result.messages.forEach((msg) => {
if (msg.type === 'dependency') this.addDependency(msg.file)
Expand Down