Branding Page #303
Branding Page #303
Conversation
|
Cool. Tested it, and on a "normal" screen (retina looks fine) the logo at the top left has some rough edges:
I don't know where these rough edges around the cube come from and if it's fixable? The branding page looks good :). Maybe run |
|
@SpaceK33z yea I see that as well, I'll play around with it. It seems odd that a vector would render that way. |
|
@SpaceK33z haven't found a solution to the rough edges yet although I did add a link to the branding page in the footer. I think once you review again we should just get this merged since you said it's somewhat time sensitive. I started working on the Navigation a bit but realized it's going to lead to some other more serious organizational changes which I think should be pushed to another PR. I can continue looking into what's going on with the svgs over there as well. Funny thing for me is I only see those rough edges on my external monitor, on my macbook display it looks sharp. |
|
Allright merging. I'm looking with @indri-indri if we can fix the logo. |
The vectors had very rough edges on some screens (see webpack/webpack.js.org#303 (comment)). This was probably because the vectors were rotated with css. Also, the filesize was relatively huge and had a lot of unnecessary paths. I did this: - Open in Illustrator - Remove all groups - Save - Repeat for all vectors - Run `cd logo && svgo -f .`
Still a WIP
Adding a branding page for easy downloading of webpack design assets and updating the Navigation component to better display the growing number of sections/pages. See #297 for the related discussion.