Deploy #390
Merged
Deploy #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script tag in `get-started/index.md` is incorrectly placed. If someone tries to execute the code to demonstrate how browsers load global variables, they're going to get an error that the browser can't read `appendChild` of undefined because `document.body` won't exist yet. The script tag should be placed at the bottom of the body so that they don't get confused (although this is a pretty inconsequential thing and the whole point of this part of the tutorial is to tell people not to code this way lol).
Since `index.js` is supposed to live inside `app`, it might be confusing to just tell users to create `index.html` without prefixing it with `app/`. Otherwise, the path to `index.js` in the html file will get a 404 back.
Since the example seems to continue assuming that `index.html` lives in the root folder, I modified the edit frmo the last commit to instead change how `index.html` accesses `index.js`
This tells ESLint not to extend any config up the directory tree, which (for example) makes it easier to be used as a submodule.
Define the ESLint config as root
…i (no content yet)
…match color scheme
Webpack colors for the site
feat(pluginapi): implement separate directory structure for plugins api
Initial work from previous PR
The nyan reporter causes thousands of unnecessary lines in the Travis CI output which made it hard to know what test failed Fixes #330
* feat(loaderapi): create initial loader api * chore(loadersapi): Clean up grammar and spelling, make markdown for type information more colorful * fix(loadersapi): corrected typo in comments * Update loaders.md Fix links * Update loaders.md Revert config links fix (looks like it just breaks more) * Update loaders.md Doing some guess work. Trying the plugins api URL this time to fix.
Refactoring and Fixes
Fixed mobile menu alignment
Better wording and grammar / punctuation fixes for first part of rules documentation
Improved spacing and color scheme of search
Swipable Menu (From #366)
Inline code + selection colors
Deduplicate target options and improve descriptions
Getting Started Clarifications
Fix invalid syntax on splash page
update antwar version
SpaceK33z
approved these changes
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.