Skip to content

1.0.21

Latest

Choose a tag to compare

@Natshah Natshah released this 18 Nov 12:26
43a44af

What changed since 1.0.20

From testing round 10: the robustness and security of the dashboard. Update soon, above all if you start the dashboard with node server.js on a machine others can reach.

Security

  • A dashboard started with node server.js (outside a container) listens on 127.0.0.1 only; WORKSPACE_LISTEN opens it to the network, and the start banner says so. It answers only to its own host names, terminal sockets included: localhost, IP addresses, *.ddev.site, the hub's domain and WORKSPACE_ALLOWED_HOSTS. Before, any machine on the network, or a web page through DNS rebinding, could drive it (#445, #446).
  • Markdown pages (a project's CHANGELOG, the docs) and the assistant's answers are shown as text: HTML in them no longer runs in the page, and OPEN: opens only a site of this machine (#447, #448).
  • Every value a form passes to a command is quoted for the shell: $(…) or backticks in a build argument, a prompt, a summary or an AI item's description no longer run, and argparse.sh quotes the values it reads (#449, #450, #469, #470).
  • core, backups and commands are never a workspace; one named core served settings.yml with its secrets (#467, #468).
  • The doc editor no longer reads or writes through a link that leads out of the workspace (#455, #456).
  • Settings files stay readable by their owner only after any save; a workspace's settings are placed with mode 600, and so are backups (#457, #458).

Fixed

  • No action, branch or plugin ends the dashboard's process, and a malformed % escape answers 400 (#451, #452).
  • A project name, a plugin spec, a branch or an item's owner never starts with a dash, so it can never be read as an option (#453, #454).
  • The same request sent several times at once starts its command once (#459, #460).
  • A closed terminal ends its script and screen client (#461, #462).
  • A settings value with a line break is written so that the file still parses (#463, #464).
  • The host runner's session list is replaced in one step, never read half written (#465, #466); two flaky tests fixed (#471, #472).
  • images-providers/ ships in the package: every image action answered 500 (#473, #474).

Install or update: npm install -g @webship.co/workspace@1.0.21, then webship-workspace update ~/workspace.