Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid mu-plugins only works with underscored key: mu_plugins #619

Closed
1 of 3 tasks
seanclen opened this issue Sep 8, 2021 · 1 comment
Closed
1 of 3 tasks

Forbid mu-plugins only works with underscored key: mu_plugins #619

seanclen opened this issue Sep 8, 2021 · 1 comment
Labels

Comments

@seanclen
Copy link

seanclen commented Sep 8, 2021

Describe the bug
According to the example configuration in the movefile.yml-configurations-explained article, the key to forbid pushing/pulling must-use plugins is mu-plugins:

production:
  forbid:
    push:
      db: false
      plugins: false
      themes: false
      languages: false
      uploads: false
      mu-plugins: true
    pull:
      db: false
      plugins: false
      themes: false
      languages: false
      uploads: false
      mu-plugins: true

However, in my environment, this only works when I use an underscore in the key (mu_plugins:). While I can get the operation to behave properly, Doctor will return some errors in the config, see below for details.

production:
  forbid:
    push:
      db: false
      plugins: false
      themes: false
      languages: false
      uploads: false
      mu_plugins: true
    pull:
      db: false
      plugins: false
      themes: false
      languages: false
      uploads: false
      mu_plugins: true

Wordmove command
Command used on the CLI: wordmove pull -e production -m or wordmove pull -e production --all

Environment (please complete the following information):

  • OS: Ubuntu 18.04.3 LTS
  • Ruby: ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux]
  • Wordmove: 5.2.1

Doctor

  • wordmove doctor is all green with mu-plugins key
  • [/forbid/push/mu_plugins] key 'mu_plugins:' is undefined. with mu_plugins key
  • [/forbid/pull/mu_plugins] key 'mu_plugins:' is undefined. with mu_plugins key
alessandro-fazzi added a commit that referenced this issue Sep 14, 2021
…_schema_validator

Fix mu-plugins key in mu_plugins. Fixes #619
@alessandro-fazzi
Copy link
Member

Hello @seanclen ,

5.2.2 is out with the fix and the documentation was updated accordingly.

Thank you so much!

alessandro-fazzi added a commit that referenced this issue Dec 26, 2021
Fix bug in AdaptRemoteDb

Undefined method `waring` was called on logger

Fix wrong signature on method call in AdaptRemoteDb

Warn when db adapt is skipper

SetupContextForDb won't run unless necessary

Update some log messages for better clarity

Fix mu-plugins key in mu_plugins. Fixes #619

Please the rubocop

Remove FTP support and cleanup as consequently

Re-implement #597 in this branch

Improve wpcli_search_replace_command with argument check

Add yard documentation

Fix bug in FilterAndSetupTasksToRun action

Was getting key by string on a symbolized hash

Migreate from Thor do dry-cli

Improve UX a bit w/ better log messages

Remove unused WordpressDirectory::HelperMethods module

Re-enable --debug flag

Update version: will stick to a pre-release

Update scaffold and namespace for organizers

WIP: re-implement FTP support

WIP: re-implement FTP support

Fix typo and reword a variable

WIP: re-implement FTP support

WIP: re-implement FTP support

WIP: re-implement FTP support

WIP: re-implement FTP support

WIP: re-implement FTP support

WIP: re-implement FTP support

WIP: re-implement FTP support

WIP: re-implement FTP support

Update get_file_spec

Update hook_spec

Update rspec config

Add adapt_local_db_spec

Various cleanups, typos, rubocop disables

Fix Wordmove::Movefile by removing - never triggered - wrong logic

Update deps and please the (new) rubocop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants