Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial S02: Show "recruit the right units" when the player has gold #4433

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

stevecotton
Copy link
Contributor

It's confusing when it pops up on turn 12, regardless of the game state. My
leader is normally on the other side of the river from my keep, and I always
wonder "what about my play triggered that?"

Move the message to be part of the "I now have enough gold to recruit more
units" hint.

@stevecotton stevecotton added Ready for testing Issues for which a potential fix is available but untested. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign labels Oct 6, 2019
@Wedge009
Copy link
Member

Wedge009 commented Oct 7, 2019

I don't see an issue with this, but just wondering: is it really easy for a new player to reach turn 18? I know the second scenario is much larger than the first but I don't remember the timing of turns.

@stevecotton
Copy link
Contributor Author

I don't see an issue with this, but just wondering: is it really easy for a new player to reach turn 18? I know the second scenario is much larger than the first but I don't remember the timing of turns.

At the moment it's possible (and even likely) for the orcs to win against a new player: #4399 (comment) . There's a lot of changes that would make the tutorial better, but for now assume that the player might really get stuck on the north bank of the river.

@Wedge009
Copy link
Member

Wedge009 commented Oct 8, 2019

I see no reason not to merge this then.

@stevecotton
Copy link
Contributor Author

Ah, I've just realised why you were asking about turn 18 - the "I now have enough gold" message triggers on turn 6 or 7. The diff makes it look like the message is moving from turn 12 to turn 18, but there's a lot of lines between where it came from and where it moves to.

It's confusing when it pops up on turn 12, regardless of the game state. My
leader is normally on the other side of the river from my keep, and I always
wonder "what about my play triggered that?"

Move the message to be part of the "I now have enough gold to recruit more
units" hint.
@stevecotton
Copy link
Contributor Author

Adding an unrelated whitespace fix in the same file.

@stevecotton stevecotton merged commit 80a2ace into wesnoth:1.14 Oct 8, 2019
@stevecotton stevecotton deleted the tutorial_timing_right_units branch October 8, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign Ready for testing Issues for which a potential fix is available but untested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants