Removing Bug which allows users to enter whitespace which is not accepted as a valid username #237
Conversation
…pted. Users mistakenly enter space which strikes an error, to stop this, entering space is ignored and not included, instead of throwing an error.
| }, | ||
| inputFormatters: [FilteringTextInputFormatter.deny(new RegExp(r"\s\b|\b\s"))], | ||
| onSaved: (value) { | ||
| _authData['username'] = value!; |
There was a problem hiding this comment.
Perhaps it would be better to just trim the whitespaces when saving to _authdata?
There was a problem hiding this comment.
Yes It would be better , but What happens is when we enter a whitespace the regexp catches it and throws an error, Normal People will be frustrated by seeing an Error, It spoils our User Experience, So what we do as a developer is we ignore those mistakes made by the users, That is what most important in UX, So inorder to improve our UX(User Experience) we must ignore the mistake and not throw an error.
There was a problem hiding this comment.
yeah I meant instead of the regex, there might be some corner cases where the user only enters white spaces or somthing like that but we can probably live with that
There was a problem hiding this comment.
So this is a valid PR and I get a hactober-accepted label ;)
…pted.
Users mistakenly enter space which strikes an error, to stop this, entering space is ignored and not included, instead of throwing an error.
Proposed Changes
Related Issues (if applicable)
Please check that the PR fulfills these requirements