Skip to content

Removing Bug which allows users to enter whitespace which is not accepted as a valid username #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Removing Bug which allows users to enter whitespace which is not accepted as a valid username #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/screens/auth_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ class _AuthCardState extends State<AuthCard> {
}
return null;
},
inputFormatters: [FilteringTextInputFormatter.deny(new RegExp(r"\s\b|\b\s"))],
onSaved: (value) {
_authData['username'] = value!;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be better to just trim the whitespaces when saving to _authdata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes It would be better , but What happens is when we enter a whitespace the regexp catches it and throws an error, Normal People will be frustrated by seeing an Error, It spoils our User Experience, So what we do as a developer is we ignore those mistakes made by the users, That is what most important in UX, So inorder to improve our UX(User Experience) we must ignore the mistake and not throw an error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I meant instead of the regex, there might be some corner cases where the user only enters white spaces or somthing like that but we can probably live with that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is a valid PR and I get a hactober-accepted label ;)

},
Expand Down