Skip to content

✨ Image logging #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jan 20, 2021
Merged

✨ Image logging #125

merged 25 commits into from
Jan 20, 2021

Conversation

@lalmei
Copy link
Contributor

@lalmei lalmei commented Jan 19, 2021

No description provided.

andyndang
andyndang requested changes Jan 19, 2021
View reviewed changes
@lalmei lalmei requested a review from andyndang January 19, 2021 09:39
andyndang
andyndang reviewed Jan 19, 2021
View reviewed changes
@andyndang
Copy link
Contributor

FYI you'll want to add a section here with PIL as a dependency:
https://github.com/whylabs/whylogs-python/blob/mainline/setup.cfg#L87

andyndang
andyndang requested changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just feedback from documentation and direct import of PIL in some critical code paths.

I want to make sure we don't require PIL to run basic whylogs

lalmei and others added 4 commits January 19, 2021 12:57
@lalmei @andyndang
Update src/whylogs/app/logger.py
39319c0 
Co-authored-by: Andy Dang <26821974+andyndang@users.noreply.github.com>
@lalmei @andyndang
Update src/whylogs/core/image_profiling.py
b649fb4 
Co-authored-by: Andy Dang <26821974+andyndang@users.noreply.github.com>
@lalmei
📚 documenting the trackImage
e558a68
@lalmei
✔️
a658d99
lalmei and others added 2 commits January 19, 2021 19:03
@lalmei
📚 minor doc string missing
baa8292
@lalmei @andyndang
Update src/whylogs/core/image_profiling.py
919eb13 
Co-authored-by: Andy Dang <26821974+andyndang@users.noreply.github.com>
lalmei
lalmei commented Jan 20, 2021
View reviewed changes
@andyndang
Copy link
Contributor

I noticed notebooks/Test.ipynb is committed? Do we have a better name for the notebook?

andyndang
andyndang approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@lalmei lalmei merged commit e2e586e into mainline Jan 20, 2021
@lalmei lalmei mentioned this pull request Jan 20, 2021
Closed
@lalmei lalmei deleted the WHY-1928_dataset_class branch May 1, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyndang andyndang andyndang approved these changes

@bernease bernease Awaiting requested review from bernease

@ibackus ibackus Awaiting requested review from ibackus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lalmei @andyndang