Skip to content

Commit bf89b30

Browse files
Require testpack to succeed for all Node versions
The workaround for #66 seems to be no longer necessary.
1 parent 10f2c6b commit bf89b30

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

.github/workflows/tests.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,9 @@ jobs:
1919
fail-fast: false
2020
matrix:
2121
node-version: [18.x]
22-
require-successful-testpack: [true]
2322
include:
2423
- node-version: 20.x
25-
require-successful-testpack: false
2624
- node-version: lts/*
27-
require-successful-testpack: false
2825

2926
steps:
3027
- name: Checkout repository
@@ -49,8 +46,6 @@ jobs:
4946

5047
- run: npx testpack-cli --keep=@types/*,ts-jest,typescript jest.config.js tsconfig.test.json src/e2e.spec.ts
5148
working-directory: ./packages/regex-to-strings
52-
# Workaround for #66
53-
continue-on-error: ${{ !matrix.require-successful-testpack }}
5449

5550
- name: Upload test coverage report to Codecov
5651
uses: codecov/codecov-action@v5.4.0

0 commit comments

Comments
 (0)