Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): add VS Code workspace file (take 2) #4107

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Conversation

skorfmann
Copy link
Contributor

This reverts commit 6344bc0.

I was reverted in #4100 due to #4099 - a hangar test failing on node20.

Tried to reproduce it locally without success. So, trying it in CI again.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@skorfmann skorfmann requested a review from a team as a code owner September 6, 2023 18:39
@monadabot
Copy link
Contributor

monadabot commented Sep 6, 2023

Console preview environment is available at https://wing-console-pr-4107.fly.dev 🚀

Updated (UTC): 2023-09-08 13:47

@skorfmann
Copy link
Contributor Author

@staycoolcall911 how were you able to reproduce this locally?

@staycoolcall911
Copy link
Contributor

@staycoolcall911 how were you able to reproduce this locally?

If I'm not mistaken, it was simply:

  1. nvm install 20
  2. Then ran the hangar tests: pnpm turbo test --filter=hangar

Does it not reproduce for you locally? I'm available to help tomorrow morning if you need assistance

@skorfmann
Copy link
Contributor Author

skorfmann commented Sep 7, 2023

  • nvm install 20
  • Then ran the hangar tests: pnpm turbo test --filter=hangar

Right, so v20.6.0 got released recently which is not working on main either on my machine. So, I don't think it's related to this particular PR. It seems related somehow to this cdktf according to the stack traces.

node v20.5.1 works fine.

 FAIL  src/plugins.test.ts [ src/plugins.test.ts ]
TypeError: Class extends value undefined is not a constructor or null
 ❯ Object.<anonymous> ../../node_modules/.pnpm/cdktf@0.17.3_constructs@10.2.70/node_modules/cdktf/lib/terraform-provider.ts:18:49
 ❯ Object.<anonymous> ../../node_modules/.pnpm/cdktf@0.17.3_constructs@10.2.70/node_modules/cdktf/lib/terraform-module.ts:5:1

@MarkMcCulloh MarkMcCulloh changed the title Revert "chore(repo): revert add VS Code workspace file 3929 (#4100)" chore(repo): add VS Code workspace file (take 2) Sep 8, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

Thanks for contributing, @skorfmann! This PR will now be added to the merge queue, or immediately merged if skorfmann/workspaces is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Sep 14, 2023
@mergify mergify bot merged commit 947c97a into main Sep 14, 2023
22 checks passed
@mergify mergify bot deleted the skorfmann/workspaces branch September 14, 2023 11:38
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.30.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants