-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): implement cloud.Bucket inflight method metadata for AWS targets and Simulator #4338
Conversation
a176d12
to
927a3f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up @exoego - this looks like a great start!
I think we need two more things:
- Add a test written in Wing to our examples directory here: https://github.com/winglang/wing/tree/main/examples/tests/sdk_tests/bucket
- I suspect we also need to specify what permissions are needed by
metadata
- check out this function:export function calculateBucketPermissions(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
061e88f
to
5cfe0cc
Compare
@Chriscbr Request was addressed. |
5cfe0cc
to
bcb23b6
Compare
Thanks, but no, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stellar work @exoego! 🎉
Thanks for contributing, @exoego! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.37.2. |
Closes #4331
Closes #4330
This PR implements inflgiht method
Bucket.metadata
for AWS.Other implementations are stubbed.
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.