Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): implement cloud.Bucket inflight method metadata for AWS targets and Simulator #4338

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Sep 29, 2023

Closes #4331
Closes #4330

This PR implements inflgiht method Bucket.metadata for AWS.
Other implementations are stubbed.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 29, 2023
@exoego exoego marked this pull request as ready for review September 29, 2023 14:29
@exoego exoego requested a review from a team as a code owner September 29, 2023 14:29
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @exoego - this looks like a great start!

I think we need two more things:

  1. Add a test written in Wing to our examples directory here: https://github.com/winglang/wing/tree/main/examples/tests/sdk_tests/bucket
  2. I suspect we also need to specify what permissions are needed by metadata - check out this function:
    export function calculateBucketPermissions(

libs/wingsdk/src/cloud/bucket.ts Show resolved Hide resolved
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@exoego exoego changed the title feat(sdk): implement cloud.Bucket inflight method metadata for AWS targets feat(sdk): implement cloud.Bucket inflight method metadata for AWS targets and Simulator Sep 29, 2023
@exoego exoego force-pushed the aws-objectmetadata branch 3 times, most recently from 061e88f to 5cfe0cc Compare September 30, 2023 00:56
@exoego
Copy link
Contributor Author

exoego commented Sep 30, 2023

@Chriscbr Request was addressed.

@revitalbarletz
Copy link
Contributor

Hey @exoego !!! How about joining our slack? It is easier to address some questions over there and we have a great community :) so its totally win win !

@exoego
Copy link
Contributor Author

exoego commented Oct 7, 2023

How about joining our slack

Thanks, but no, thanks.
I do not like that Google-unsearchable places (e.g. Slack or Discord) are used for questions and discussions in OSS community.

Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stellar work @exoego! 🎉

@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

Thanks for contributing, @exoego! This PR will now be added to the merge queue, or immediately merged if aws-objectmetadata is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Oct 11, 2023
@mergify mergify bot merged commit d5fc08f into winglang:main Oct 11, 2023
15 checks passed
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.37.2.

@exoego exoego deleted the aws-objectmetadata branch October 11, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants