[2019] Remove legacy commit status override

[gr2m]

When a pull request status context has the same name as a check, one does not override the other, instead they are both listed:

That means that a previous "pending" commit status can block a pul pull_request indefinitely, as the new version no longer sets commit but uses checks instead.

So for a transition period the app checks if there is a commit status set and overwrites it, unfortunately there is now way to simply delete a status instead. That’s why the app requires the read/write permission for commit status for the same transition period.

I have not yet decided how long this transition period will be, but at least until 2019

follow up for #94

[gr2m]

I check every now and then if there are still requests from the legacy account. And yes, even one year after I created the new version which prompted the new permissions, and half a year after I started to nudge users to accept the permissions, there are still hundreds of requests 🤷‍♂ 5 people and organizations accepted the new permissions in the past week alone.

I'll continue to watch the usage numbers, but with the current tendency I think I'll leave the legacy commit status handling for another 6 months at least

[gr2m]

There were still 323 installations that didn't accept the new permissions after over 2 years, so the probably never will. I uninstalled the WIP app for these installations now, which means I can finally remove the legacy code.

[github-actions]

🎉 This issue has been resolved in version 4.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀