Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): expose thumbprint and userhandle with e2ei cert (WPB-8606) #2739

Conversation

mchenani
Copy link
Member

@mchenani mchenani commented May 3, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Exposing userHandle and the MLS Client Thumbprint with E2EI certificate.

Issues

Needed in the AR.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented May 3, 2024

Test Results

2 851 tests   2 833 ✔️  4m 39s ⏱️
       7 suites       18 💤
       7 files           0

Results for commit fac4a2a.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented May 3, 2024

Datadog Report

All test runs a3cf804 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2739 122 11m 37.13s Link
kalium-jvm 0 0 0 2879 106 8m 53s Link

@mchenani mchenani enabled auto-merge (squash) May 3, 2024 09:51
@mchenani mchenani merged commit a1fdb7f into release/android-cycle-4.6 May 3, 2024
17 checks passed
@mchenani mchenani deleted the fix/expose-thumbprint-userhandle-with-e2ei-cert branch May 3, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants