Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): expose thumbprint and userhandle with e2ei cert (WPB-8606) 🍒 #2741

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 3, 2024

BugWPB-8606 [Android] When downloading another users certificate, saved file has wrong name

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Exposing userHandle and the MLS Client Thumbprint with E2EI certificate.

Issues

Needed in the AR.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict to be resolved

…into fix/expose-thumbprint-userhandle-with-e2ei-cert-cherry-pick
mchenani and others added 3 commits May 23, 2024 18:08
…/E2eiCertificate.kt

Co-authored-by: Vitor Hugo Schwaab <vitor@schwaab.dev>
…-with-e2ei-cert-cherry-pick' into fix/expose-thumbprint-userhandle-with-e2ei-cert-cherry-pick
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mchenani mchenani enabled auto-merge (squash) May 23, 2024 16:39
Copy link
Contributor Author

github-actions bot commented May 23, 2024

Test Results

3 046 tests   2 941 ✔️  3m 12s ⏱️
   529 suites     105 💤
   529 files           0

Results for commit bd808e5.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/expose-thumbprint-userhandle-with-e2ei-cert-cherry-pick
Commit report: 4b8291e
Test service: kalium-jvm

✅ 0 Failed, 2941 Passed, 105 Skipped, 9.72s Total Time

@mchenani mchenani merged commit c9ae87a into release/candidate May 23, 2024
19 checks passed
@mchenani mchenani deleted the fix/expose-thumbprint-userhandle-with-e2ei-cert-cherry-pick branch May 23, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants