Skip to content

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Oct 2, 2025

Changes

  • It became the default in v5 so it makes no sense to keep it now
  • Lot of trial and error, maybe what I made is total nonsense. REVIEW CAREFULLY

Testing

Should pass

Docs

Changeset

@florian-lefebvre florian-lefebvre self-assigned this Oct 2, 2025
Copy link

changeset-bot bot commented Oct 2, 2025

🦋 Changeset detected

Latest commit: 4ffbdea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@florian-lefebvre
Copy link
Member Author

!preview render-script

Copy link
Contributor

github-actions bot commented Oct 2, 2025

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--render-script" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--render-script tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-render-script-20251002135111) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-render-script-20251002135111" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-render-script-20251002135111 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-render-script-20251002135111

@florian-lefebvre
Copy link
Member Author

!preview render-script

Copy link
Contributor

github-actions bot commented Oct 3, 2025

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--render-script" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--render-script tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-render-script-20251003120459) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-render-script-20251003120459" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-render-script-20251003120459 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-render-script-20251003120459

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You should prune the old snapshots. Since you changed the title of the current snapshots, new ones were created, but the old ones are still there

@florian-lefebvre florian-lefebvre merged commit f4d1a54 into next Oct 3, 2025
5 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/remove-render-script-option branch October 3, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants