feat: remove renderScript option

.changeset/neat-camels-raise.md

@@ -0,0 +1,5 @@
+---
+"@astrojs/compiler": major
+---
+
+Removes `renderScript` from `TransformOptions`. It is now the default and only behavior 

cmd/astro-wasm/astro-wasm.go

@@ -135,11 +135,6 @@ func makeTransformOptions(options js.Value) transform.TransformOptions {
 		scopedStyleStrategy = "where"
 	}
 
-	renderScript := false
-	if jsBool(options.Get("renderScript")) {
-		renderScript = true
-	}
-
 	return transform.TransformOptions{
 		Filename:                filename,
 		NormalizedFilename:      normalizedFilename,
@@ -153,7 +148,6 @@ func makeTransformOptions(options js.Value) transform.TransformOptions {
 		ScopedStyleStrategy:     scopedStyleStrategy,
 		TransitionsAnimationURL: transitionsAnimationURL,
 		AnnotateSourceFile:      annotateSourceFile,
-		RenderScript:            renderScript,
 	}
 }
 

internal/printer/__printer_js__/Empty_script.snap

@@ -34,7 +34,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
 
-return $$render``;
+return $$render`${$$renderScript($$result,"?astro&type=script&index=0&lang.ts")}`;
 }, undefined, undefined);
 export default $$Component;
 ```

internal/printer/__printer_js__/component_with_only_a_script.snap

@@ -34,7 +34,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
 
-return $$render``;
+return $$render`${$$renderScript($$result,"?astro&type=script&index=0&lang.ts")}`;
 }, undefined, undefined);
 export default $$Component;
 ```

internal/printer/__printer_js__/define_vars_on_script_with_StaticExpression_turned_on.snap

@@ -34,7 +34,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
 
-return $$render`<script>var one = 'one';</script><script>(function(){${$$defineScriptVars({foo:'bar'})}var three = foo;})();</script><script>(function(){${$$defineScriptVars({foo:'bar'})}var four = foo;})();</script>`;
+return $$render`<script>var one = 'one';</script>${$$renderScript($$result,"?astro&type=script&index=0&lang.ts")}<script>(function(){${$$defineScriptVars({foo:'bar'})}var three = foo;})();</script><script>(function(){${$$defineScriptVars({foo:'bar'})}var four = foo;})();</script>`;
 }, undefined, undefined);
 export default $$Component;
 ```

internal/printer/__printer_js__/maybeRenderHead_not_printed_for_hoisted_scripts.snap

@@ -34,7 +34,7 @@ export const $$metadata = $$createMetadata("/projects/app/src/pages/page.astro",
 
 const $$Page = $$createComponent(($$result, $$props, $$slots) => {
 
-return $$render`${$$renderComponent($$result,'Layout',Layout,{})}`;
+return $$render`${$$renderScript($$result,"/projects/app/src/pages/page.astro?astro&type=script&index=0&lang.ts")}${$$renderComponent($$result,'Layout',Layout,{})}`;
 }, '/projects/app/src/pages/page.astro', undefined);
 export default $$Page;
 ```

internal/printer/__printer_js__/multibyte_character___script.snap

@@ -34,7 +34,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
 
-return $$render`${$$maybeRenderHead($$result)}<a class="test">ツ</a>`;
+return $$render`${$$renderScript($$result,"?astro&type=script&index=0&lang.ts")}${$$maybeRenderHead($$result)}<a class="test">ツ</a>`;
 }, undefined, undefined);
 export default $$Component;
 ```

internal/printer/__printer_js__/script__renderScript__true_.snap → internal/printer/__printer_js__/script.snap

@@ -1,5 +1,5 @@
 
-[TestPrinter/script_(renderScript:_true) - 1]
+[TestPrinter/script - 1]
 ## Input
 
 ```

internal/printer/__printer_js__/script_before_elements.snap

@@ -34,7 +34,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
 
-return $$render`${$$maybeRenderHead($$result)}<div></div>`;
+return $$render`${$$renderScript($$result,"?astro&type=script&index=0&lang.ts")}${$$maybeRenderHead($$result)}<div></div>`;
 }, undefined, undefined);
 export default $$Component;
 ```

internal/printer/__printer_js__/script_external__renderScript__true_.snap → internal/printer/__printer_js__/script_external.snap

@@ -1,5 +1,5 @@
 
-[TestPrinter/script_external_(renderScript:_true) - 1]
+[TestPrinter/script_external - 1]
 ## Input
 
 ```

internal/printer/__printer_js__/script_external_in_expression__renderScript__true_.snap → internal/printer/__printer_js__/script_external_in_expression.snap

@@ -1,5 +1,5 @@
 
-[TestPrinter/script_external_in_expression_(renderScript:_true) - 1]
+[TestPrinter/script_external_in_expression - 1]
 ## Input
 
 ```

internal/printer/__printer_js__/script_hoist_with_frontmatter.snap

@@ -36,7 +36,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
 
-return $$render``;
+return $$render`${$$renderScript($$result,"?astro&type=script&index=0&lang.ts")}`;
 }, undefined, undefined);
 export default $$Component;
 ```

internal/printer/__printer_js__/script_hoist_without_frontmatter.snap

@@ -36,7 +36,7 @@ export const $$metadata = $$createMetadata(import.meta.url, { modules: [], hydra
 const $$Component = $$createComponent(($$result, $$props, $$slots) => {
 
 return $$render`${$$maybeRenderHead($$result)}<main>
-
+                                ${$$renderScript($$result,"?astro&type=script&index=0&lang.ts")}
 </main>`;
 }, undefined, undefined);
 export default $$Component;

internal/printer/__printer_js__/script_in_expression__renderScript__true_.snap → internal/printer/__printer_js__/script_in_expression.snap

@@ -1,5 +1,5 @@
 
-[TestPrinter/script_in_expression_(renderScript:_true) - 1]
+[TestPrinter/script_in_expression - 1]
 ## Input
 
 ```

internal/printer/__printer_js__/script_mixed_handled_and_inline__renderScript__true_.snap → internal/printer/__printer_js__/script_mixed_handled_and_inline.snap

@@ -1,5 +1,5 @@
 
-[TestPrinter/script_mixed_handled_and_inline_(renderScript:_true) - 1]
+[TestPrinter/script_mixed_handled_and_inline - 1]
 ## Input
 
 ```

internal/printer/__printer_js__/script_multiple__renderScript__true_.snap → internal/printer/__printer_js__/script_multiple.snap

@@ -1,5 +1,5 @@
 
-[TestPrinter/script_multiple_(renderScript:_true) - 1]
+[TestPrinter/script_multiple - 1]
 ## Input
 
 ```

internal/printer/__printer_js__/selectedcontent_element_in_customizable_select.snap

@@ -1,3 +1,4 @@
+
 [TestPrinter/selectedcontent_element_in_customizable_select - 1]
 ## Input
 

internal/printer/__printer_js__/selectedcontent_self-closing_element.snap

@@ -1,3 +1,4 @@
+
 [TestPrinter/selectedcontent_self-closing_element - 1]
 ## Input
 

internal/printer/printer_test.go

@@ -51,7 +51,6 @@ type testcase struct {
 	source           string
 	only             bool
 	transitions      bool
-	transformOptions transform.TransformOptions
 	filename         string
 }
 
@@ -845,70 +844,37 @@ import Widget2 from '../components/Widget2.astro';
 			source: `<script>Here</script><div></div>`,
 		},
 		{
-			name:   "script (renderScript: true)",
+			name:   "script",
 			source: `<main><script>console.log("Hello");</script>`,
-			transformOptions: transform.TransformOptions{
-				RenderScript: true,
-			},
 			filename: "/src/pages/index.astro",
 		},
 		{
-			name:   "script multiple (renderScript: true)",
+			name:   "script multiple",
 			source: `<main><script>console.log("Hello");</script><script>console.log("World");</script>`,
-			transformOptions: transform.TransformOptions{
-				RenderScript: true,
-			},
 			filename: "/src/pages/index.astro",
 		},
 		{
-			name:   "script external (renderScript: true)",
+			name:   "script external",
 			source: `<main><script src="./hello.js"></script>`,
-			transformOptions: transform.TransformOptions{
-				RenderScript: true,
-			},
 			filename: "/src/pages/index.astro",
 		},
 		{
-			name:   "script external in expression (renderScript: true)",
+			name:   "script external in expression",
 			source: `<main>{<script src="./hello.js"></script>}`,
-			transformOptions: transform.TransformOptions{
-				RenderScript: true,
-			},
 			filename: "/src/pages/index.astro",
 		},
 		{
-			// maintain the original behavior, though it may be
-			// unneeded as renderScript is now on by default
-			name:     "script external in expression (renderScript: false)",
-			source:   `<main>{<script src="./hello.js"></script>}`,
-			filename: "/src/pages/index.astro",
-		},
-		{
-			name:   "script in expression (renderScript: true)",
+			name:   "script in expression",
 			source: `<main>{true && <script>console.log("hello")</script>}`,
-			transformOptions: transform.TransformOptions{
-				RenderScript: true,
-			},
-			filename: "/src/pages/index.astro",
-		},
-		{
-			name:     "script in expression (renderScript: false)",
-			source:   `<main>{false && <script>console.log("hello")</script>}`,
 			filename: "/src/pages/index.astro",
 		},
 		{
-			name:   "script inline (renderScript: true)",
+			name:   "script inline",
 			source: `<main><script is:inline type="module">console.log("Hello");</script>`,
-			transformOptions: transform.TransformOptions{
-				RenderScript: true,
-			},
 		},
 		{
-			name:   "script mixed handled and inline (renderScript: true)",
+			name:   "script mixed handled and inline",
 			source: `<main><script>console.log("Hello");</script><script is:inline>console.log("World");</script>`,
-			transformOptions: transform.TransformOptions{
-				RenderScript: true,
-			},
 			filename: "/src/pages/index.astro",
 		},
 		{
@@ -2105,10 +2071,8 @@ import Analytics from '../components/Analytics.astro';
 			}
 
 			hash := astro.HashString(code)
-			// combine from tt.transformOptions
 			transformOptions := transform.TransformOptions{
 				Scope:                   hash,
-				RenderScript:            tt.transformOptions.RenderScript,
 			}
 			transform.ExtractStyles(doc, &transformOptions)
 			transform.Transform(doc, transformOptions, h) // note: we want to test Transform in context here, but more advanced cases could be tested separately