Skip to content

fix/connent duration prop #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 21, 2021
Merged

fix/connent duration prop #1228

merged 2 commits into from
Mar 21, 2021

Conversation

lidord-wix
Copy link
Contributor

Description

duration prop of floatingButton wasn't in use.

Changelog

Fix floatingButton duration prop

@lidord-wix lidord-wix requested a review from ethanshar March 17, 2021 09:02
@ethanshar ethanshar requested a review from Inbal-Tish March 21, 2021 09:48
@ethanshar ethanshar assigned Inbal-Tish and unassigned ethanshar Mar 21, 2021
@ethanshar ethanshar removed their request for review March 21, 2021 09:49
@Inbal-Tish Inbal-Tish merged commit 129b33b into master Mar 21, 2021
M-i-k-e-l added a commit that referenced this pull request Mar 21, 2021
@M-i-k-e-l
Merge branch 'master' into Infra/support-svg-image
2aa0f13 
* master:
  fix/connent duration prop (#1228)
  Colors - add transparent (#1234)
  fix screen UI (#1230)
  Fix exported Image static types
  Use reanimatedv2 API in our components (#1224)
  Infra/eslint v2 (#1193)
@lidord-wix lidord-wix deleted the fix/floatingButton_duration_prop branch April 19, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inbal-Tish Inbal-Tish Inbal-Tish approved these changes

Assignees

@Inbal-Tish Inbal-Tish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidord-wix @Inbal-Tish @ethanshar