Feat/ TabController.TabBar style #1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Jun 3, 2021
| const TabBar = (props: Props) => { | ||
| const { | ||
| items: propsItems, | ||
| spreadItems = true, |
There was a problem hiding this comment.
I'd move = true to defaultProps.
|
|
||
| const indicatorContainerStyle = useMemo(() => { | ||
| return [styles.tabBar, !_.isUndefined(height) && {height}, {backgroundColor}]; | ||
| return [styles.tabBar, {flex: spreadItems && 1}, !_.isUndefined(height) && {height}, {backgroundColor}]; |
There was a problem hiding this comment.
Android crashes because of this :(
M-i-k-e-l
approved these changes
Jun 6, 2021
ethanshar
reviewed
Jun 8, 2021
There was a problem hiding this comment.
@lidord-wix
I know it's been merged, but please see my comments.
CC @M-i-k-e-l
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1263
Add
wideIndicatorprop to make the indicator widerAdd
spreadItemsprop to make the items spread (default is true).Changelog
Add
wideIndicatorandspreadItemsprops to TabController.TabBar