Skip to content

KeyboardTrackingView - add 'bottomViewColor' prop #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 27, 2022
Merged

KeyboardTrackingView - add 'bottomViewColor' prop #2013

merged 10 commits into from
Apr 27, 2022

Conversation

Inbal-Tish
Copy link
Collaborator

@Inbal-Tish Inbal-Tish commented Apr 26, 2022 •
edited
Loading

Description

KeyboardTrackingView - add 'bottomViewColor' prop.
I also organized the API files a bit and fixed another 2 keys in different files (not related but needed to be done).
solves issue #1898

Changelog

KeyboardTrackingView - add 'bottomViewColor' prop.

@Inbal-Tish
KeyboardTrackingView - add 'bottomViewColor' prop
f098b71
@Inbal-Tish
Merge branch 'master' of github.com:wix/react-native-ui-lib into feat…
ebc0dfb 
…/KeyboardTrackingView_bottomViewColor

# Conflicts:
#	lib/components/Keyboard/KeyboardTracking/keyboardAwareInsetsView.api.json
@Inbal-Tish
fix master merge
6dc16e0
@Inbal-Tish
Moving back to UIColor
2fdcad1
@Inbal-Tish
fix
63cc033
@Inbal-Tish Inbal-Tish mentioned this pull request Apr 26, 2022
Closed
7 tasks
@Inbal-Tish Inbal-Tish requested a review from M-i-k-e-l April 26, 2022 09:47
M-i-k-e-l
M-i-k-e-l reviewed Apr 26, 2022
View reviewed changes
M-i-k-e-l
M-i-k-e-l approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, I suggest to either do the following in this PR or create a ticket for it: I think that iOSScrollBehavior in KeyboardAccessoryViewProps is the same as scrollBehavior in KeyboardTrackingViewProps, and that IOS_SCROLL_BEHAVIORS should actually be inside of KeyboardTrackingView (WDYT?), maybe we should deprecate it and import it as well from KeyboardTrackingViewProps?

@Inbal-Tish
Copy link
Collaborator Author

Approved, I suggest to either do the following in this PR or create a ticket for it: I think that iOSScrollBehavior in KeyboardAccessoryViewProps is the same as scrollBehavior in KeyboardTrackingViewProps, and that IOS_SCROLL_BEHAVIORS should actually be inside of KeyboardTrackingView (WDYT?), maybe we should deprecate it and import it as well from KeyboardTrackingViewProps?

Good idea - I opened another PR - #2016

@Inbal-Tish Inbal-Tish merged commit 3a9027e into master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Inbal-Tish @M-i-k-e-l