Skip to content

StackAggregator - fix children update #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 22, 2022
Merged

StackAggregator - fix children update #2103

merged 13 commits into from
Aug 22, 2022

Conversation

Inbal-Tish
Copy link
Collaborator

@Inbal-Tish Inbal-Tish commented Jun 27, 2022 •
edited
Loading

Description

StachAggregator - fix children update.
Moving to a functional component.
fix for issue #2048

Changelog

StachAggregator - fix children update.

@Inbal-Tish Inbal-Tish added the WIP label Jun 27, 2022
@Inbal-Tish Inbal-Tish changed the title Infra/stack aggregator function StackAggregator - fix children update Jun 29, 2022
@Inbal-Tish Inbal-Tish requested review from ethanshar July 3, 2022 06:10
@ethanshar ethanshar assigned M-i-k-e-l and unassigned ethanshar Jul 3, 2022
@ethanshar ethanshar requested a review from M-i-k-e-l July 3, 2022 11:08
@ethanshar ethanshar assigned ethanshar and unassigned M-i-k-e-l Jul 4, 2022
@ethanshar ethanshar removed the request for review from M-i-k-e-l July 4, 2022 13:52
@ethanshar
Copy link
Collaborator

@Inbal-Tish
I noticed that the first time you open the stack it doesn't have an animation.
It works fine on the master version

@Inbal-Tish
Copy link
Collaborator Author

@Inbal-Tish I noticed that the first time you open the stack it doesn't have an animation. It works fine on the master version

Fixed

ethanshar
ethanshar requested changes Jul 24, 2022
View reviewed changes
src/components/stackAggregator/index.tsx Outdated
const [firstItemHeight, setFirstItemHeight] = useState<number>();
const [isCollapsed, setIsCollapsed] = useState(collapsed);

LayoutAnimation.configureNext(LayoutAnimation.Presets.easeInEaseOut);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't trigger a LayoutAnimation like that. It will be called in each render and will also affect everything on the screen, not just the stack aggregator

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ethanshar ethanshar enabled auto-merge (squash) August 22, 2022 07:06
@ethanshar ethanshar merged commit 77c9113 into master Aug 22, 2022
@Inbal-Tish Inbal-Tish deleted the infra/StackAggregator_function branch August 23, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Inbal-Tish @ethanshar @M-i-k-e-l