Infra/refactor view - convert to function component and use modifiers and themeProps hooks #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
changed the title
M-i-k-e-l
reviewed
Jul 27, 2022
| </Element> | ||
| ); | ||
| return container; | ||
| }, [useSafeArea, animated, reanimated]); |
There was a problem hiding this comment.
I can see useSafeArea changing, but probably not the other two
There was a problem hiding this comment.
I agree, And if they won't change there's no harm having them here (:
There was a problem hiding this comment.
It might have some performance implications, but they are probably minor
M-i-k-e-l
approved these changes
Jul 27, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert View to a function component to reduce render hierarchy
depends on #2145
Changelog
Convert View to a function component to reduce render hierarchy