Create an imperative API for TabController for setting tab imperatively #2197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
reviewed
Aug 17, 2022
src/components/tabController/useImperativeTabControllerHandle.ts
Outdated
Show resolved
Hide resolved
| useSafeArea = false, | ||
| children | ||
| }: PropsWithChildren<TabControllerProps>) { | ||
| const TabController = React.forwardRef((props: PropsWithChildren<TabControllerProps>, ref: React.Ref<any>) => { |
There was a problem hiding this comment.
I think this can resolve the bottom ignores, you decide if it's better:
// @ts-expect-error
const TabController: ForwardRefExoticComponent<
PropsWithoutRef<TabControllerProps> & RefAttributes<TabControllerImperativeMethods>
// eslint-disable-next-line max-len
> & TabControllerStatics = React.forwardRef((props: PropsWithChildren<TabControllerProps>, ref: React.Ref<TabControllerImperativeMethods>) => {
There was a problem hiding this comment.
It doesn't solve the bottom ignores
There was a problem hiding this comment.
Strange, it does for me. let me know if you want to look at this together
There was a problem hiding this comment.
Maybe I did something wrong or misunderstood..
Do you want to create a (separate) PR with what u meant?
There was a problem hiding this comment.
It works for me, but I think it breaks the props, so forget about it
Co-authored-by: Miki Leib <38354019+M-i-k-e-l@users.noreply.github.com>
M-i-k-e-l
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create an imperative API for TabController for setting tab imperatively
Changelog
Create an imperative API for TabController for setting tab imperatively