Skip to content

docsite - add "note" entry #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 28, 2022
Merged

docsite - add "note" entry #2244

merged 5 commits into from
Sep 28, 2022

Conversation

Inbal-Tish
Copy link
Collaborator

Description

docsite - add "note" to components and props api.

Changelog

docsite - add "note" to components and props api.

@Inbal-Tish
Copy link
Collaborator Author

@ethanshar The site is not responsive when adding the

(marked with ####) to the script.

@ethanshar
Copy link
Collaborator

@Inbal-Tish
The error is coming from FloatingButton doc file.
You can see the error when you run npm start in docuilib folder.
Screen Shot 2022-09-12 at 13 47 46

The reason it started now is because you added support to show the note.
The error is because of the format of how we documented the <testID> prop. We need to avoid < and > chars.

See how I fixed it in Incubator.Dialog api.json file

@ethanshar
Copy link
Collaborator

@Inbal-Tish Approved, looks good 👌
We'll need to update the private script as well

@Inbal-Tish Inbal-Tish merged commit 3155f8d into master Sep 28, 2022
@Inbal-Tish Inbal-Tish deleted the infra/Docsite_add_note branch November 6, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants