Skip to content

Fixed textField placeholder color, support in design token #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

adids1221
Copy link
Contributor

Description

TextField presenter now supports design tokens.

Changelog

TextField presenter now supports design tokens.

@lidord-wix lidord-wix merged commit cbd63f9 into master Oct 11, 2022
@ethanshar
Copy link
Collaborator

@adids1221 @lidord-wix
I came across this PR and I suspect it might have an issue...
There's a conversion of color to a string, but it's inside an if statement that verifies the color is an object. so it's must be an object. why do we convert it to a string.. returning an object can lead to a bug

@adids1221 adids1221 deleted the fix/TextField_presenter_placeholder_color branch November 16, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants