DynamicFonts - add isFontFamilyDownloaded #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-i-k-e-l
added
the
Important for Next Release
ethanshar
approved these changes
Oct 4, 2023
| @@ -173,4 +173,23 @@ export default class DynamicFonts { | |||
| public async isFontDownloaded(fontName: string, fontExtension: FontExtension): Promise<boolean> { | |||
| return await this.fontDownloader.isFontDownloaded(fontName, fontExtension); | |||
| } | |||
|
|
|||
| public async isFontFamilyDownloaded(rootUri: string, | |||
There was a problem hiding this comment.
It sounds like you named the method with the purpose you need it for while technically this method checks if multiple fonts are downloaded, right?
There was a problem hiding this comment.
It checks if the whole font family is downloaded, yes; all the methods in this API are this way.
We can try to think of a different API if you like, but I'm merging for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DynamicFonts - add isFontFamilyDownloaded
Changelog
None
Additional info
None