Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react-native to 0.71.12 #2816

Merged
merged 5 commits into from Dec 5, 2023
Merged

Upgrade react-native to 0.71.12 #2816

merged 5 commits into from Dec 5, 2023

Conversation

M-i-k-e-l
Copy link
Contributor

@M-i-k-e-l M-i-k-e-l commented Nov 21, 2023 •
edited

Description

  • Upgrade react-native to 0.71.12 (including types)
    This is for building iOS on the new mac OS (Sonoma) on M1 chips
    @ethanshar Please verify it still works on your mac 馃檹

  • Upgrade reanimated to version 3.4.0.

  • Move from npm to yarn (commit yarn.lock) (FYI @Inbal-Tish @nitzanwix)

Changelog

Upgrade react-native to 0.71.12
Upgrade reanimated to version 3.4.0

Additional info

None

@ethanshar ethanshar merged commit 95ded5e into master Dec 5, 2023
1 check passed
@ethanshar
Copy link
Collaborator

@M-i-k-e-l
I happen to run a version from our master with this PR changes
I notice an issue with this line

const {hitSlop, ...otherContainerProps} = containerProps;

If containerProps is undefined, destructing hitSlop here throws an error

@M-i-k-e-l M-i-k-e-l deleted the infra/upgrade-react-native-to-0.71.12 branch December 6, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@M-i-k-e-l @ethanshar