Skip to content

Colors - update danger design tokens colors (a11y) #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025

Conversation

adids1221
Copy link
Contributor

Description

Update danger design tokens colors.
Changed - $backgroundDangerHeavy, $textDangerLight, $iconDangerLight, $outlineDanger from red30 to red10.

Note that now:
$textDangerLight equal to $textDanger and $iconDangerLight equal to $iconDanger

Changelog

Colors - Update danger design tokens colors (a11y).

Additional info

MADS-4756

@adids1221 adids1221 removed the request for review from Inbal-Tish June 25, 2025 07:58
@adids1221 adids1221 requested a review from Inbal-Tish June 25, 2025 07:58
@@ -57,7 +57,7 @@ export default {
$iconSuccessLight: colorsPalette.green30,
$iconMajor: colorsPalette.orange10,
$iconDanger: colorsPalette.red10,
$iconDangerLight: colorsPalette.red30,
$iconDangerLight: colorsPalette.red10,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a note to deprecate iconDangerLight

@@ -43,7 +43,7 @@ export default {
$textSuccessLight: colorsPalette.green30,
$textMajor: colorsPalette.orange10,
$textDanger: colorsPalette.red10,
$textDangerLight: colorsPalette.red30,
$textDangerLight: colorsPalette.red10,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a note to deprecate textDangerLight

@@ -22,7 +22,7 @@ export default {
$backgroundWarningLight: colorsPalette.yellow70,
$backgroundMajorLight: colorsPalette.orange80,
$backgroundMajorHeavy: colorsPalette.orange30,
$backgroundDangerHeavy: colorsPalette.red30,
$backgroundDangerHeavy: colorsPalette.red10,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a note to change backgroundDangerHeavy to backgroundDanger

@Inbal-Tish Inbal-Tish assigned adids1221 and unassigned Inbal-Tish Jun 25, 2025
@Inbal-Tish Inbal-Tish enabled auto-merge (squash) June 25, 2025 08:16
@Inbal-Tish Inbal-Tish merged commit 7f661a1 into master Jun 25, 2025
1 check passed
@Inbal-Tish Inbal-Tish deleted the fix/update_danger_tokens_colors branch June 25, 2025 08:17
@adids1221 adids1221 assigned Inbal-Tish and unassigned adids1221 Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants