Carousel - page control hit slop fix a11y #3763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Jun 18, 2025
| @@ -201,6 +202,10 @@ class PageControl extends PureComponent<PageControlProps, State> { | |||
| getColorStyle(index === currentPage, color, inactiveColor), | |||
| getSizeStyle(size, index, currentPage, enlargeActive) | |||
| ]} | |||
| hitSlop={{ | |||
| top: hitSlopValue, | |||
There was a problem hiding this comment.
Did you on purpose didn't assign the left/right hit slop?
There was a problem hiding this comment.
Yes, Alexey approved it also.
When assigning left/right they are overlapping each other, we don't want to change the UX specs of the PageControl for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Carousel - pageControl set hitSlop as part of a11y fix.
Moved
getAccessibleHitSlopfunction intoStyleUtilsto make reuse instead of duplications.Changelog
Carousel - pageControl set hitSlop as part of a11y fix.
Additional info
MADS-4757