AnimatedImage - use useEffect instead of onLoadStart #3806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AnimatedImage - fix wrong load order
For some reason in RN77 the Image callbacks' order is wrong (iOS only):
onLoad
is called beforeonLoadStart
- I've verified this on a new RN77 project (I did not find a ticket about this in their issues).I've decided to keep Android and iOS aligned and not keep the correct solution for Android even though it does work there.
Edit: I've also decided not to fix this in
Image
, mainly because it would have required refactoringImage
to a function component.Changelog
Additional info
Ticket 4821