Skip to content

Conversation

emilisb
Copy link
Member

@emilisb emilisb commented Sep 24, 2019

updateModifiers and getAlteredModifiersOptions were doing deep comparisons with prop values, and children prop was not excluded, leading to really long execution times (in some cases, 500-5000ms per render).

I excluded children, forwardedRef, style and testID props, these are not required to extract modifiers.

@ethanshar ethanshar merged commit bf37375 into master Oct 22, 2019
@ethanshar ethanshar deleted the exclude-few-props-from-modifiers branch May 17, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants