Skip to content

Use PropTypes.elementType for components #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2020
Merged

Use PropTypes.elementType for components #644

merged 1 commit into from
Feb 9, 2020

Conversation

oliver-ni
Copy link
Contributor

PropTypes.elementType is the right prop type to expect a component. Using PropTypes.func as it currentl is causes issues with class components.

@ethanshar ethanshar self-requested a review February 9, 2020 17:38
@ethanshar ethanshar self-assigned this Feb 9, 2020
@ethanshar ethanshar merged commit 2a40f02 into wix:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliver-ni @ethanshar