Skip to content

Add\move testIDs in Dialog\Modal to better support detox 17 #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2020
Merged

Add\move testIDs in Dialog\Modal to better support detox 17 #892

merged 2 commits into from
Aug 18, 2020

Conversation

M-i-k-e-l
Copy link
Collaborator

No description provided.

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar August 12, 2020 08:24
@ethanshar
Copy link
Collaborator

@M-i-k-e-l
I approved the PR, but I see there're conflicts.
You can fix and then merge

@M-i-k-e-l M-i-k-e-l merged commit c3d1ec9 into master Aug 18, 2020
@M-i-k-e-l M-i-k-e-l deleted the feat/test-ids-for-detox-17 branch September 21, 2020 09:57
@M-i-k-e-l M-i-k-e-l restored the feat/test-ids-for-detox-17 branch September 21, 2020 10:00
@M-i-k-e-l M-i-k-e-l deleted the feat/test-ids-for-detox-17 branch September 21, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @ethanshar