Prepare the library to be released as a npm package #47
Conversation
manicki
changed the title
| "irc": "irc://irc.freenode.net/wikidata" | ||
| }, | ||
| "require": { | ||
| "data-values/javascript": "~0.8.0|~0.7.0", |
There was a problem hiding this comment.
Uh, we never made it compatible with DataValues JavaScript 0.9?
| @@ -1,13 +1,48 @@ | |||
| { | |||
| "name": "wikibase-serialization", | |||
There was a problem hiding this comment.
Again, tab-indention should be the norm for .json files. But this is for later.
| @@ -1,4 +1,5 @@ | |||
| /** | |||
| * @ignore | |||
| */ | |||
| window.wikibase = window.wikibase || {}; | |||
There was a problem hiding this comment.
Why does this use window., but the line below does not? In my opinion this a) should be consistent, and b) avoid window. when not really necessary (e.g. certain headless JS engines might need it).
There was a problem hiding this comment.
It was needed in this line exactly to have phantom js understand where wikibase object is defined.
It was not apparently needed elsewhere. The whole weirdness is probably going to be irrelevant once this lib uses some proper way of registering its stuff (module.exports or whatever you do in JS this month).
Requires releases of dependency libraries as npm packages (see: wmde/DataValuesJavaScript#129 and wmde/WikibaseDataModelJavaScript#82).
Includes a commit running Qunit tests using npm test initially submitted as #45.