Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.0 #129

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Release 0.10.0 #129

merged 1 commit into from
Oct 6, 2017

Conversation

manicki
Copy link
Member

@manicki manicki commented Oct 5, 2017

Looks like I messed up and cannot reopen #127, then submitting again.

This should not be merged before #128 was, otherwise release notes are a lie.

@thiemowmde
Copy link
Contributor

What I wrote in #127 (comment) still applies. Let's please include the breaking changes in #122 and #123 in this release. Otherwise we will release 2.0 next week, and that would be silly in my opinion.

@lucaswerkmeister
Copy link
Member

#122 and #123 are merged now, so should this be turned back into 1.0.0?

@manicki
Copy link
Member Author

manicki commented Oct 6, 2017

Actually, after talking with @c089 we agreed to keep it on 0.* for now. It will now be an npm package, but a bit clumsy one (the way of using it is not what you'd normally do with npm packages). Therefore we thought it might be better to not call it 1.0.0 for now, if there is an opportunity (and there is one, as this package is still on 0.* right now).

Copy link
Contributor

@thiemowmde thiemowmde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the formatter code is gone I'm fine with making this a 1.0 release. ;-)

@manicki manicki merged commit 9d3d515 into master Oct 6, 2017
@manicki manicki deleted the rel100 branch October 6, 2017 15:25
thiemowmde pushed a commit that referenced this pull request Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants