fix(logger): return undefined if file path not found

wmfs · Nov 30, 2021 · 67a6a65 · 67a6a65
1 parent 80edb3c
commit 67a6a65
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/lib/plugin/components/services/logger/index.js b/lib/plugin/components/services/logger/index.js
@@ -13,7 +13,7 @@ class Logger {
       ? process.env.LOGGER
       : (process.env.LOGGER === '*' ? 'trace' : 'info')
     this.loggerOutputFilePath = generateFilePath(process.env.LOGGER_OUTPUT_DIR_PATH)
-    options.messages.detail(this.loggerOutputFilePath ? `Output logs to ${this.loggerOutputFilePath}` : 'No output file')
+    options.messages.info(this.loggerOutputFilePath ? `Output logs to ${this.loggerOutputFilePath}` : 'No output file')
     this.logger = this.createLogger()
   }
 
@@ -47,8 +47,8 @@ class Logger {
 }
 
 function generateFilePath (dirpath) {
-  if (!dirpath) return {}
-  if (!fs.existsSync(dirpath)) return {}
+  if (!dirpath) return
+  if (!fs.existsSync(dirpath)) return
 
   const now = moment()
   const filename = `${now.format('YYYYMMDD-HHmm')}.log`
@@ -81,12 +81,9 @@ function generateFilePath (dirpath) {
 // }
 
 function createMultistream (filepath, level) {
-  const streams = [
-    { stream: pino.destination(filepath), level }
-  ]
-  if (process.env.NODE_ENV === 'development') {
-    streams.push({ stream: pinoPretty() })
-  }
+  const streams = []
+  if (filepath) streams.push({ stream: pino.destination(filepath), level })
+  if (process.env.NODE_ENV === 'development') streams.push({ stream: pinoPretty() })
   return pino.multistream(streams)
 }