Skip to content

OpenGrokBot v0.3.1: a second look at webhooks

Choose a tag to compare

@wolfqing wolfqing released this 30 Oct 13:28
· 114 commits to main since this release

Fixes from a second review of 0.3.0 — mostly webhooks: redeliveries that were dropped, signed requests that
could be replayed, and bodies buffered before they were refused — plus a Node 26 bot image and steadier tests.

Security

  • A webhook delivery refused because the last run was still going is no longer remembered as "seen", so
    GitHub's redelivery of it runs instead of being dropped as a duplicate.
  • A captured signed webhook request can no longer be replayed under a different (or no) delivery id: the
    signature itself is remembered per routine.
  • Oversized webhook bodies are refused as they arrive instead of being buffered first, so a caller with a bad key
    cannot make the gateway allocate the whole request.
  • A space-separated list of channels, handles or email addresses ("#ops #dev", "bob@acme.com alice@acme.com")
    is treated as a list and never gets Always allow, as the changelog already promised.
  • The action log keeps query strings and fragments out of page addresses, and masks tokens, passwords and
    authorization headers in logged commands.

Changed

  • The bot image is built on node:26-bookworm-slim (the current LTS line) instead of Node 22.
  • The bot image build gives apt 300 seconds per download and ten retries instead of the defaults, so
    fetching Chromium over a slow mirror no longer fails the build.
  • CI runs on actions/checkout v7, actions/setup-node v7 and pnpm/action-setup v6, all on the Node 24 action runtime.

Fixed

  • A standing rule that differed only by case or trailing punctuation could be saved twice and then removed by
    neither route; saving now dedupes the way removal compares, and the panel reports an ambiguous match as such.
  • Answering a question card twice at the same moment started two turns; the second now gets 409.
  • Web: a reply that arrived while two thread loads overlapped (switching away and straight back) could vanish
    until the next reconnect; a question card whose answer the gateway refused stayed on "Answered"; two timing-
    dependent tests.
  • Web tests that failed now and then on a busy machine. The full-page App tests acted in the gap between the first
    render and the effects that run after it, before the live connection existed or while a "close the panel on a
    thread switch" effect was still queued; they now wait for both. A render test could also run past the 5-second
    limit when the CPU was saturated, and its unfinished typing then leaked into the next test; web tests now get 15
    seconds.

Full changelog: v0.3.0...v0.3.1