This repository was archived by the owner on Oct 4, 2019. It is now read-only.
Remove the 'visible' property from the variations endpoint and adds status #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ( is_array( $request['image'] ) ) { | ||
| $image = $request['image']; | ||
| if ( is_array( $image ) ) { | ||
| $image['position'] = 0; |
There was a problem hiding this comment.
I think this can be removed now.
claudiosanches
approved these changes
Jun 1, 2017
emdashcodes
force-pushed
the
add/variations-rest-api-status
branch
from
1cff6c6 to
d000aa4
Compare
added 2 commits
June 1, 2017 13:20
Don't return parent image for variations.
This was referenced Sep 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the change I made in woocommerce/woocommerce#15216 -- but I'm moving it to the feature plugin. Just want a quick review since this adds
prepare_object_for_responseandprepare_object_for_databaseto the v3 endpoint.cc @claudiosanches