[Payment Method Improvements] Update change due based on user input #11586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backwardstruck
added
type: enhancement
Generated by 🚫 Danger |
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11586 +/- ##
=========================================
Coverage 40.32% 40.33%
Complexity 5200 5200
=========================================
Files 1087 1087
Lines 63229 63239 +10
Branches 8667 8668 +1
=========================================
+ Hits 25500 25505 +5
- Misses 35435 35440 +5
Partials 2294 2294 ☔ View full report in Codecov by Sentry. |
Base automatically changed from
11525-change-due-calculator-ui-part-4
to
11525-change-due-calculator-ui-part-3
May 27, 2024 15:26
kidinov
reviewed
May 28, 2024
| @@ -52,4 +58,12 @@ class ChangeDueCalculatorViewModel @Inject constructor( | |||
| fun onBackPressed() { | |||
| _navigationEvent.value = Unit | |||
| } | |||
|
|
|||
| fun updateAmountReceived(amount: BigDecimal) { | |||
There was a problem hiding this comment.
Would be nice to add a test on this logic
There was a problem hiding this comment.
For sure, thanks for the suggestion. I will add it in this draft PR:
#11594
kidinov
approved these changes
May 28, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11584
Description
I added the
unit-tests-exemptionlabel as this PR is dependent on others and will likely change. Updating the test is ticketed here:#11542
This PR is to update the change due correctly based on the user input for how much cash was given.
Testing instructions
Expected: You should see the correct values update for Cash received and Change Due
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.