-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payment Method Improvements] Implement record transaction details to order note functionality #11594
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11594 +/- ##
============================================
+ Coverage 40.13% 40.22% +0.08%
+ Complexity 5219 5202 -17
============================================
Files 1093 1089 -4
Lines 63900 63523 -377
Branches 8793 8724 -69
============================================
- Hits 25646 25549 -97
+ Misses 35932 35670 -262
+ Partials 2322 2304 -18 ☔ View full report in Codecov by Sentry. |
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/changeduecalculator/ChangeDueCalculatorScreen.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to move forward and land it on the current release I
- Resolved merge conflicts
- Adjusted margins and some UI stuff
- Moved network call out from the main scope
- Added loading indicator to a button
- Removed unused nav action
- Made the release note public, not internal as this a user-facing change
- Color theme of the toggle (used to be red or something like that)
Feel free to revert/do any changes if that doesn't make sense to you
05-30--10-26.mp4
Thanks a lot for the help! I checked all those changes you made. Some were pretty serious and I don't see any that need to be reverted. |
Closes: #11585
Description
This PR implements the functionality to record transaction details as an order note upon returning to the order screen after marking the order as complete.
Also updated the unit test based on this suggestion:
#11586 (comment)
And addresses feedback from this PR:
#11585
Testing instructions
OTHER_PAYMENT_METHODS
Implement record transaction details to order note
toggle to enabled (and try again without switching it)Expected:
Images
Addressed feedback so 16.dp is consistently used for horizontal padding across various elements to align them.
Used 8.dp or 16.dp for vertical paddings ensuring consistent spacing within the UI elements.
Ensured the 'Change Due' section and record transaction note have proper padding and spacing.
Aligned the button and input field using consistent horizontal padding.
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.