HTML API: Use strict in_array comparison for checking URI attributes #7196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
commented
Aug 14, 2024
| @@ -3667,7 +3667,7 @@ public function set_attribute( $name, $value ): bool { | |||
| * | |||
| * @see https://html.spec.whatwg.org/#attributes-3 | |||
| */ | |||
| $escaped_new_value = in_array( $comparable_name, wp_kses_uri_attributes() ) ? esc_url( $value ) : esc_attr( $value ); | |||
| $escaped_new_value = in_array( $comparable_name, wp_kses_uri_attributes(), true ) ? esc_url( $value ) : esc_attr( $value ); | |||
There was a problem hiding this comment.
@xknown, @aaronjorbin, @audrasjb This was added in https://core.trac.wordpress.org/changeset/58473 where you're propped. Can you confirm whether this loose in_array was intentional?
It seems like we want strict as we expect to be comparing strings, but I want to confirm first.
If we'd prefer to keep the loose comparison that's fine, I'd like to apply a different change because PHPCS is flagging this line as a warning now.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
approved these changes
Aug 14, 2024
pento
pushed a commit
that referenced
this pull request
Aug 14, 2024
This patch modifies the URL-escaping code in the HTML API to rely on strict comparisons. This prevents accidental matching via type-coercion. Developed in #7196 Follow-up to [58473]. Props jonsurrell. git-svn-id: https://develop.svn.wordpress.org/trunk@58897 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 14, 2024
This patch modifies the URL-escaping code in the HTML API to rely on strict comparisons. This prevents accidental matching via type-coercion. Developed in WordPress/wordpress-develop#7196 Follow-up to [58473]. Props jonsurrell. Built from https://develop.svn.wordpress.org/trunk@58897 git-svn-id: http://core.svn.wordpress.org/trunk@58293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Aug 14, 2024
This patch modifies the URL-escaping code in the HTML API to rely on strict comparisons. This prevents accidental matching via type-coercion. Developed in WordPress/wordpress-develop#7196 Follow-up to [58473]. Props jonsurrell. Built from https://develop.svn.wordpress.org/trunk@58897 git-svn-id: https://core.svn.wordpress.org/trunk@58293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
aslamdoctor
pushed a commit
to aslamdoctor/wordpress-develop
that referenced
this pull request
Dec 28, 2024
This patch modifies the URL-escaping code in the HTML API to rely on strict comparisons. This prevents accidental matching via type-coercion. Developed in WordPress#7196 Follow-up to [58473]. Props jonsurrell. git-svn-id: https://develop.svn.wordpress.org/trunk@58897 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a strict argument to an
in_arraycheck that seems to be comparing strings with no need for loose comparison.Follow-up to [58473].
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.